Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix assertion in test-console #20557

Closed
wants to merge 1 commit into from
Closed

test: fix assertion in test-console #20557

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 6, 2018

Move the assertion after the second call to console.time() to
actually make sure that the time is not reset.

Refs: #20442

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@lpinca
test: fix assertion in test-console
41d91c4 
Move the assertion after the second call to `console.time()` to
actually make sure that the time is not reset.

Refs: nodejs#20442
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 6, 2018
@lpinca
Copy link
Member Author

lpinca commented May 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14683/

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 12, 2018
@trivikr
Copy link
Member

trivikr commented May 14, 2018

node-test-commit-windows-fanned CI rerun: https://ci.nodejs.org/job/node-test-commit-windows-fanned/17953/

@addaleax
Copy link
Member

Landed in 60ef7d1

@addaleax addaleax closed this May 14, 2018
addaleax pushed a commit that referenced this pull request May 14, 2018
@lpinca @addaleax
test: fix assertion in test-console
60ef7d1 
Move the assertion after the second call to `console.time()` to
actually make sure that the time is not reset.

Refs: #20442

PR-URL: #20557
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax
Copy link
Member

Adding dont-land-on labels because this depends on a semver-major PR, let me know if that’s wrong

@lpinca lpinca deleted the fix/test-console-assertion branch May 14, 2018 19:34
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 25, 2018
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lpinca @trivikr @addaleax @jasnell @cjihrig @targos @nodejs-github-bot