-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move http2-misbehaving-flow-control-paused #20580
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least as currently written, test-http2-misbehaving-flow-control-paused is sensitive to resource constraints and has been observed to be unreliable in CI. Move it to sequential so it is not competing with other tests for resources.
Example CI failure: https://ci.nodejs.org/job/node-test-commit-freebsd/17556/nodes=freebsd11-x64/console 03:07:37 not ok 921 parallel/test-http2-misbehaving-flow-control-paused
03:07:37 ---
03:07:37 duration_ms: 0.281
03:07:37 severity: fail
03:07:37 exitcode: 1
03:07:37 stack: |-
03:07:37 (node:14866) ExperimentalWarning: The http2 module is an experimental API.
03:07:37 assert.js:77
03:07:37 throw new AssertionError(obj);
03:07:37 ^
03:07:37
03:07:37 AssertionError [ERR_ASSERTION]: function should not have been called at /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-http2-misbehaving-flow-control-paused.js:72
03:07:37 at ServerHttp2Stream.mustNotCall (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/common/index.js:540:12)
03:07:37 at ServerHttp2Stream.emit (events.js:187:15)
03:07:37 at endReadableNT (_stream_readable.js:1091:14)
03:07:37 at process._tickCallback (internal/process/next_tick.js:63:19)
03:07:37 ... |
Replicating the failure from the command line: $ tools/test.py -j 96 --repeat 192 test/parallel/test-http2-misbehaving-flow-control-paused.js
=== release test-http2-misbehaving-flow-control-paused ===
Path: parallel/test-http2-misbehaving-flow-control-paused
(node:85322) ExperimentalWarning: The http2 module is an experimental API.
assert.js:77
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: function should not have been called at /Users/trott/io.js/test/parallel/test-http2-misbehaving-flow-control-paused.js:72
at ServerHttp2Stream.mustNotCall (/Users/trott/io.js/test/common/index.js:540:12)
at ServerHttp2Stream.emit (events.js:187:15)
at endReadableNT (_stream_readable.js:1086:12)
at process._tickCallback (internal/process/next_tick.js:63:19)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http2-misbehaving-flow-control-paused.js
[SNIP] |
@apapirovski Cool! Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least as currently written,
test-http2-misbehaving-flow-control-paused is sensitive to resource
constraints and has been observed to be unreliable in CI. Move it to
sequential so it is not competing with other tests for resources.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes