Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move http2-misbehaving-flow-control-paused #20580

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 7, 2018

At least as currently written,
test-http2-misbehaving-flow-control-paused is sensitive to resource
constraints and has been observed to be unreliable in CI. Move it to
sequential so it is not competing with other tests for resources.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

At least as currently written,
test-http2-misbehaving-flow-control-paused is sensitive to resource
constraints and has been observed to be unreliable in CI. Move it to
sequential so it is not competing with other tests for resources.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 7, 2018
@Trott
Copy link
Member Author

Trott commented May 7, 2018

Example CI failure:

https://ci.nodejs.org/job/node-test-commit-freebsd/17556/nodes=freebsd11-x64/console

03:07:37 not ok 921 parallel/test-http2-misbehaving-flow-control-paused
03:07:37   ---
03:07:37   duration_ms: 0.281
03:07:37   severity: fail
03:07:37   exitcode: 1
03:07:37   stack: |-
03:07:37     (node:14866) ExperimentalWarning: The http2 module is an experimental API.
03:07:37     assert.js:77
03:07:37       throw new AssertionError(obj);
03:07:37       ^
03:07:37     
03:07:37     AssertionError [ERR_ASSERTION]: function should not have been called at /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-http2-misbehaving-flow-control-paused.js:72
03:07:37         at ServerHttp2Stream.mustNotCall (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/common/index.js:540:12)
03:07:37         at ServerHttp2Stream.emit (events.js:187:15)
03:07:37         at endReadableNT (_stream_readable.js:1091:14)
03:07:37         at process._tickCallback (internal/process/next_tick.js:63:19)
03:07:37   ...

@Trott
Copy link
Member Author

Trott commented May 7, 2018

Replicating the failure from the command line:

$ tools/test.py -j 96 --repeat 192 test/parallel/test-http2-misbehaving-flow-control-paused.js 
=== release test-http2-misbehaving-flow-control-paused ===                     
Path: parallel/test-http2-misbehaving-flow-control-paused
(node:85322) ExperimentalWarning: The http2 module is an experimental API.
assert.js:77
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: function should not have been called at /Users/trott/io.js/test/parallel/test-http2-misbehaving-flow-control-paused.js:72
    at ServerHttp2Stream.mustNotCall (/Users/trott/io.js/test/common/index.js:540:12)
    at ServerHttp2Stream.emit (events.js:187:15)
    at endReadableNT (_stream_readable.js:1086:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http2-misbehaving-flow-control-paused.js
[SNIP]

@Trott
Copy link
Member Author

Trott commented May 7, 2018

@apapirovski
Copy link
Member

@Trott see #20556 which fixes the issue in this test.

@Trott
Copy link
Member Author

Trott commented May 7, 2018

@apapirovski Cool! Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants