repl: changes ctrl+u to delete from cursor to line start #20686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
readline
bnoordhuis
approved these changes
May 12, 2018
lib/readline.js
Outdated
| @@ -796,9 +796,7 @@ Interface.prototype._ttyWrite = function(s, key) { | |||
| break; | |||
|
|
|||
| case 'u': // delete the whole line | |||
There was a problem hiding this comment.
Can you update or remove the comment?
cjihrig
approved these changes
May 12, 2018
addaleax
approved these changes
May 12, 2018
devsnek
approved these changes
May 12, 2018
lpinca
approved these changes
May 12, 2018
lpinca
added
the
author ready
trivikr
approved these changes
May 13, 2018
BridgeAR
added
the
semver-major
BridgeAR
approved these changes
May 13, 2018
|
Hey team! Is a doc update required for this or a test ? Do let me know. 😇 |
|
I don't think we document this key binding anywhere so no update needed. |
|
@bnoordhuis I guess this could land without the docs but on the other hand it would also nice to document all key bindings properly. Even though that could happen in another PR. |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 18, 2018
Closes: nodejs#20145 PR-URL: nodejs#20686 Fixes: nodejs#20145 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in eeb1d51 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #20145
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
REPL / readline