Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: throw when entry point is null #20779

Closed
wants to merge 1 commit into from
Closed

n-api: throw when entry point is null #20779

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels May 16, 2018
@gabrielschulhof gabrielschulhof mentioned this pull request May 16, 2018
Closed
3 tasks
addaleax
addaleax approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to use node_errors.h for this, though.

@gabrielschulhof gabrielschulhof force-pushed the n-api-handle-null-init branch from f33d2a1 to 99fa5a7 Compare May 16, 2018 20:58
@gabrielschulhof
Copy link
Contributor Author

@addaleax I've changed the text of the error message to be exactly the same as the text for regular addons, i.e. "Module has no declared entry point."

Can we replace both with a node_errors.h construction without the result being semver-major?

@gabrielschulhof
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/15027/

@gabrielschulhof gabrielschulhof force-pushed the n-api-handle-null-init branch from 99fa5a7 to a2097c7 Compare May 23, 2018 23:41
@gabrielschulhof
Copy link
Contributor Author

Fixed lint. CI: https://ci.nodejs.org/job/node-test-pull-request/15068/

@gabrielschulhof
Copy link
Contributor Author

The CI failures are unrelated.

@gabrielschulhof
Copy link
Contributor Author

Landed in 9a02de7.

gabrielschulhof pushed a commit that referenced this pull request May 24, 2018
n-api: throw when entry point is null
9a02de7 
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gabrielschulhof gabrielschulhof deleted the n-api-handle-null-init branch May 24, 2018 02:16
targos pushed a commit that referenced this pull request May 25, 2018
@targos
n-api: throw when entry point is null
ba30d14 
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 29, 2018
Merged
@mhdawson mhdawson mentioned this pull request Jul 4, 2018
Merged
@MylesBorins
Copy link
Contributor

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@gabrielschulhof gabrielschulhof mentioned this pull request Jul 10, 2018
Closed
4 tasks
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Jul 14, 2018
n-api: throw when entry point is null
d4e5de2 
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 1, 2018
@MylesBorins
n-api: throw when entry point is null
b48791d 
Backport-PR-URL: #21732
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@rvagg
n-api: throw when entry point is null
7033bba 
Backport-PR-URL: #21732
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gabrielschulhof @MylesBorins @addaleax @cjihrig @nodejs-github-bot