Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: change items unknown style #20792

Closed
wants to merge 1 commit into from
Closed

util: change items unknown style #20792

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

We mainly use <> to visualize special information that is not
directly visible as property.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
util: change items unknown style
4a56d60 
We mainly use <> to visualize special information that is not
directly visible as property.
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label May 16, 2018
@BridgeAR
Copy link
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/14917/

(About semver: I am somewhat on the edge if this is a bugfix or semver-major).

@addaleax
Copy link
Member

About semver: I am somewhat on the edge if this is a bugfix or semver-major

Is there a downside to semver-major?

@addaleax addaleax added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 16, 2018
@BridgeAR
Copy link
Member Author

Is there a downside to semver-major?

No ^^

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request May 20, 2018
@BridgeAR
util: change items unknown style
e270ae9 
We mainly use <> to visualize special information that is not
directly visible as property.

PR-URL: nodejs#20792
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@BridgeAR
Copy link
Member Author

Landed in e270ae9

@BridgeAR BridgeAR closed this May 20, 2018
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 19, 2018
@BridgeAR BridgeAR deleted the change-items-unknown branch January 20, 2020 11:33
@ghost ghost deleted a comment Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@devsnek devsnek devsnek approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.