Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] 16238 and 18576 #20797

Closed
wants to merge 2 commits into from
Closed

[v8.x backport] 16238 and 18576 #20797

wants to merge 2 commits into from

Commits on May 22, 2018

  1. build: make gyp user defined variables lowercase 

    I mistakenly introduced user defined variables using uppercase
characters, reading the gyp documentation they state:
"Predefined variables. By convention, these are named with
CAPITAL_LETTERS. Predefined variables are set automatically by GYP"
and also "By convention, user-defined variables are named with
lowercase_letters."

This commit renames the user defined variables to lowercase to follow
the above mentioned convention.

PR_URL: nodejs#20797
Original PR-URL: nodejs#16238
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @danbev @yhwang
    danbev authored and yhwang committed May 22, 2018
    Configuration menu
    Copy the full SHA
    b01a26a View commit details
    Browse the repository at this point in the history

  2. build: add node_lib_target_name to cctest deps 

    Currently the cctest target depend on the node_core_target_name
target. But it is the node_lib_target_name target that compiles the
sources now which means that if a source file in src is updated the
cctest executable will not be re-linked against it, but will remain
unchanged. The code will still be compiled, just not linked which
means that if you are debugging you'll not see the changes and also a
warning will be displayed about this issue.

This commit changes the cctest target to depend on node_lib_target_name.
PR-URL: nodejs#20797
Original PR-URL: nodejs#18576
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Yihong Wang <yh.wang@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @danbev @yhwang
    danbev authored and yhwang committed May 22, 2018
    Configuration menu
    Copy the full SHA
    4aaa601 View commit details
    Browse the repository at this point in the history