Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: ignore fstat errors on user fds in fs.readFile{Sync} #20800

Closed
wants to merge 1 commit into from
Closed

fs: ignore fstat errors on user fds in fs.readFile{Sync} #20800

wants to merge 1 commit into from

Commits on Jul 27, 2018

  1. fs: ignore fstat errors on user fds in fs.readFile{Sync} 

    On Windows fstat cannot be called on std fds. In those cases,
we already know that the fd is not for a regular file and can
just use a list of buffers to store the data.

Also makes sure that we don't close fds provided by users
if we cannot call fstat on them.
    @joyeecheung
    joyeecheung committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    15e8393 View commit details
    Browse the repository at this point in the history