Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix linting error #20839

Closed
wants to merge 1 commit into from
Closed

doc: fix linting error #20839

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 19, 2018

Looks like a linting error crept in at some point

Running Markdown linter on misc docs...
COLLABORATOR_GUIDE.md
  846:46-846:66  warning  Use "V8" instead of "v8"  prohibited-strings  remark-lint

⚠ 1 warning
Makefile:1079: recipe for target 'tools/.miscmdlintstamp' failed
make[1]: *** [tools/.miscmdlintstamp] Error 1
Makefile:1178: recipe for target 'lint' failed
make: *** [lint] Error 2

Please 👍 to fast-track

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@jasnell jasnell requested a review from a team as a code owner May 19, 2018 18:02
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 19, 2018
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label May 19, 2018
@jasnell
Copy link
Member Author

jasnell commented May 19, 2018

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite/731/

lpinca
lpinca previously approved these changes May 19, 2018
View reviewed changes
Trott
Trott requested changes May 19, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this will break links. You need to make lint-md-clean && make lint-md-build and everything will be fine.

@Trott
Copy link
Member

Trott commented May 19, 2018

(Er, it won't break links, but it will make the team un-copy-paste-able.)

@Trott
Copy link
Member

Trott commented May 19, 2018

Ref: #20742

@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label May 19, 2018
@Trott
Copy link
Member

Trott commented May 19, 2018

-1 to fast-tracking (which is probably obvious since I'm -1 on the PR)

@lpinca lpinca dismissed their stale review May 19, 2018 19:39

Dismissed as per #20839 (comment)

cjihrig
cjihrig previously approved these changes May 19, 2018
View reviewed changes
@cjihrig cjihrig dismissed their stale review May 19, 2018 22:05

nothing to see here :-)

@BridgeAR
Copy link
Member

Duplicate of #20829. Closing

@BridgeAR BridgeAR closed this May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott requested changes

@cjihrig cjihrig cjihrig left review comments

@lpinca lpinca lpinca left review comments

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @Trott @BridgeAR @lpinca @cjihrig @nodejs-github-bot