Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move DeleteFnPtr into util.h #20885

Closed
wants to merge 1 commit into from
Closed

src: move DeleteFnPtr into util.h #20885

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Split out from #20876

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: move DeleteFnPtr into util.h
2ce54e5 
This is more generally useful than just in a crypto context.
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. labels May 22, 2018
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels May 22, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/18670/

@addaleax addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. and removed crypto Issues and PRs related to the crypto subsystem. labels May 22, 2018
@benjamingr
Copy link
Member

+1 for fast tracking. Feel free to 👍 if you agree.

targos
targos approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add #include "util.h" to node_crypto.h?

@joyeecheung
Copy link
Member

@targos util.h is included in env.h which is included by itself and in many headers included by node_crypto.h. I think we generally avoid unnecessary includes like this to save disk I/O.

@joyeecheung
Copy link
Member

There were some infra issues with the last CI. New CI: https://ci.nodejs.org/job/node-test-pull-request/15018/

@apapirovski apapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2018
@tniessen
Copy link
Member

Landed in 7d77068.

@tniessen tniessen closed this May 25, 2018
tniessen pushed a commit that referenced this pull request May 25, 2018
@addaleax @tniessen
src: move DeleteFnPtr into util.h
7d77068 
This is more generally useful than just in a crypto context.

PR-URL: #20885
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request May 25, 2018
@addaleax @targos
src: move DeleteFnPtr into util.h
b4519ca 
This is more generally useful than just in a crypto context.

PR-URL: #20885
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request May 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@addaleax @benjamingr @joyeecheung @tniessen @jasnell @targos @cjihrig @apapirovski @nodejs-github-bot