Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: get rid of the make_unique #20895

Merged
merged 0 commits into from
May 22, 2018
Merged

inspector: get rid of the make_unique #20895

merged 0 commits into from
May 22, 2018

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented May 22, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@eugeneo eugeneo requested a review from apapirovski May 22, 2018 21:22
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol labels May 22, 2018
@eugeneo
Copy link
Contributor Author

eugeneo commented May 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15035/

@eugeneo eugeneo mentioned this pull request May 22, 2018
Merged
3 tasks
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label May 22, 2018
@richardlau
Copy link
Member

No objections to this as a workaround, but the real issue is that non-regular CI jobs like CitGM (nodejs/build#1254) are not using the same level of compilers as the normal Node.js CI runs.

@apapirovski
Copy link
Member

Please also update src/inspector/tracing_agent.cc.

@eugeneo
Copy link
Contributor Author

eugeneo commented May 22, 2018

@apapirovski Oops - forgot to also grep the subfolders. Done.

CI: https://ci.nodejs.org/job/node-test-pull-request/15036/

@eugeneo
Copy link
Contributor Author

eugeneo commented May 22, 2018

There's a number of test failures but none of them is inspector-related (and this change is basically compiler-time only)

@eugeneo eugeneo closed this May 22, 2018
@eugeneo eugeneo deleted the no_make_unique branch May 22, 2018 23:33
@eugeneo eugeneo merged commit 7f610a1 into nodejs:master May 22, 2018
@eugeneo
Copy link
Contributor Author

eugeneo commented May 22, 2018

Landed as 7f610a1

MylesBorins pushed a commit that referenced this pull request May 23, 2018
@MylesBorins
inspector: get rid of the make_unique
4933fb8 
PR-URL: #20895
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 23, 2018
@MylesBorins
inspector: get rid of the make_unique
92dd9b5 
PR-URL: #20895
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eugeneo @richardlau @apapirovski @addaleax @TimothyGu @nodejs-github-bot