doc: removed LTS label from v4 in doc version picker #20904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
starkwang
approved these changes
May 23, 2018
Trott
approved these changes
May 23, 2018
trivikr
approved these changes
May 23, 2018
lpinca
approved these changes
May 23, 2018
vsemozhetbyt
added
the
fast-track
vsemozhetbyt
approved these changes
May 23, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
cjihrig
approved these changes
May 23, 2018
jasnell
approved these changes
May 23, 2018
|
Trying CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/746/ |
ckotzbauer
approved these changes
May 23, 2018
|
|
|
Yes, that's an unrelated failure. |
jasnell
pushed a commit
that referenced
this pull request
May 23, 2018
Fixes: #20903 PR-URL: #20904 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in c89669d |
targos
pushed a commit
that referenced
this pull request
May 25, 2018
Fixes: #20903 PR-URL: #20904 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20903
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes