Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: throw if SNICallback is not a function #20969

Closed
wants to merge 1 commit into from
Closed

tls: throw if SNICallback is not a function #20969

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 25, 2018 •
edited
Loading

If a value is passed for SNICallback and it is not a function,
createServer() will now throw.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Trott Trott added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 25, 2018
@Trott Trott added this to the 11.0.0 milestone May 25, 2018
@nodejs-github-bot nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label May 25, 2018
@Trott
tls: throw if SNICallback is not a function
2f79117 
If a value is passed for SNICallback and it is not a function,
createServer() will now throw.
@Trott Trott force-pushed the throw-on-invalid-snicallback branch from 6ada9f2 to 2f79117 Compare May 25, 2018 20:26
@Trott
Copy link
Member Author

Trott commented May 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15099/

@Trott Trott mentioned this pull request May 25, 2018
Closed
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2018
@Trott
Copy link
Member Author

Trott commented May 30, 2018

Re-running Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18398/

Trott added a commit to Trott/io.js that referenced this pull request May 31, 2018
@Trott
tls: throw if SNICallback is not a function
eadcee1 
If a value is passed for SNICallback and it is not a function,
createServer() will now throw.

PR-URL: nodejs#20969
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented May 31, 2018

Landed in eadcee1

@Trott Trott closed this May 31, 2018
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 8, 2018
@Trott Trott deleted the throw-on-invalid-snicallback branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
semver-major PRs that contain breaking changes and should be released in the next major version. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.