Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add OS X to instead of only macOS #21033

Closed
wants to merge 3 commits into from
Closed

doc: add OS X to instead of only macOS #21033

wants to merge 3 commits into from

Conversation

XadillaX
Copy link
Contributor

@XadillaX XadillaX commented May 30, 2018 •
edited
Loading

The last OS X version is 10.11 El Captian, and the first macOS version
is 10.12 Sierra. So >= 10.8 < 10.10 is called OS X and >= 10.10 is
called OS X or macOS.

Refs: https://en.wikipedia.org/wiki/MacOS#Release_history

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@XadillaX
doc: add OS X to instead of only macOS
833835a 
The last OS X version is 10.11 El Captian, and the first macOS version
is 10.12 Sierra. So >= 10.8 < 10.10 is called OS X and >= 10.10 is
called OS X or macOS.

Refs: https://en.wikipedia.org/wiki/MacOS#Release_history
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels May 30, 2018
@XadillaX XadillaX requested a review from joyeecheung May 30, 2018 10:31
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/769/

@devsnek
Copy link
Member

devsnek commented May 30, 2018

perhaps we should just explicitly refer to them by version of codename ranges? it might be less confusing

Trott
Trott previously requested changes May 31, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't introduce spaces around the slashes. (Spaces around slashes are typically for indicating line separation in poetry or song lyrics. In cases like this where the slash basically means "or", there should typically be no spaces.)

BUILDING.md Outdated
@@ -41,14 +41,14 @@ platforms in production.
|--------------|--------------|----------------------------------|----------------------|------------------|
| GNU/Linux | Tier 1 | kernel >= 2.6.32, glibc >= 2.12 | x64, arm | |
| GNU/Linux | Tier 1 | kernel >= 3.10, glibc >= 2.17 | arm64 | |
| macOS | Tier 1 | >= 10.10 | x64 | |
| macOS / OS X | Tier 1 | >= 10.10 | x64 | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no spaces around the slashes here and elsewhere, please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@Trott Trott dismissed their stale review May 31, 2018 03:11

spaces removed, thanks!

yorkie
yorkie suggested changes May 31, 2018
View reviewed changes
BUILDING.md Outdated
@@ -41,14 +41,14 @@ platforms in production.
|--------------|--------------|----------------------------------|----------------------|------------------|
| GNU/Linux | Tier 1 | kernel >= 2.6.32, glibc >= 2.12 | x64, arm | |
| GNU/Linux | Tier 1 | kernel >= 3.10, glibc >= 2.17 | arm64 | |
| macOS | Tier 1 | >= 10.10 | x64 | |
| macOS/OS X | Tier 1 | >= 10.10 | x64 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make alignment with other rows?

yorkie
yorkie approved these changes May 31, 2018
View reviewed changes
Copy link
Contributor

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me @XadillaX :p

@apapirovski
Copy link
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/892/

@apapirovski apapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2018
@addaleax
Copy link
Member

Landed in d462f8c 🎉

@addaleax addaleax closed this Jul 13, 2018
addaleax pushed a commit that referenced this pull request Jul 13, 2018
@XadillaX @addaleax
doc: add OS X to instead of only macOS
d462f8c 
The last OS X version is 10.11 El Captian, and the first macOS version
is 10.12 Sierra. So >= 10.8 < 10.10 is called OS X and >= 10.10 is
called OS X or macOS.

Refs: https://en.wikipedia.org/wiki/MacOS#Release_history

PR-URL: #21033
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 14, 2018
@XadillaX @targos
doc: add OS X to instead of only macOS
3d93273 
The last OS X version is 10.11 El Captian, and the first macOS version
is 10.12 Sierra. So >= 10.8 < 10.10 is called OS X and >= 10.10 is
called OS X or macOS.

Refs: https://en.wikipedia.org/wiki/MacOS#Release_history

PR-URL: #21033
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
@refack refack mentioned this pull request Oct 18, 2018
Merged
3 tasks
@joanzz
Copy link

joanzz commented Nov 28, 2022

OS X to instead of only macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@jasnell jasnell jasnell approved these changes

@yorkie yorkie yorkie approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

@Trott Trott Trott left review comments

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.