Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add fs.watchFile() + worker.terminate() test #21179

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jun 6, 2018

Refs: #21093 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support. labels Jun 6, 2018
@addaleax addaleax requested a review from apapirovski June 6, 2018 21:24
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 6, 2018
test/parallel/test-worker-fs-stat-watcher.js Outdated Show resolved Hide resolved
@addaleax
Copy link
Member Author

addaleax commented Jun 7, 2018

Getting related CI failures like https://ci.nodejs.org/job/node-test-commit-linuxone/1994/nodes=rhel72-s390x/testReport/junit/(root)/test/parallel_test_worker_fs_stat_watcher/:

out/Release/node[29153]: ../src/node_worker.cc:307:virtual node::worker::Worker::~Worker(): Assertion `(uv_loop_close(&loop_)) == (0)' failed.
 1: node::Abort() [out/Release/node]
 2: 0x15084c4 [out/Release/node]
 3: node::worker::Worker::~Worker() [out/Release/node]
 4: node::Environment::RunCleanup() [out/Release/node]

I’ll look into it.

@addaleax addaleax added the blocked PRs that are blocked by other issues or PRs. label Jun 7, 2018
@addaleax
Copy link
Member Author

addaleax commented Jun 7, 2018

Ok, so, this seems to expose a libuv bug, and I see no way of hacking around that. Guess this PR will have to wait for now.

libuv/libuv#1869

@addaleax
Copy link
Member Author

With libuv 1.27.0 (#26707) merged, this should now finally be ready!

CI: https://ci.nodejs.org/job/node-test-pull-request/21643/

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Mar 18, 2019
@addaleax
Copy link
Member Author

Landed in d398e89 🎉

@addaleax addaleax closed this Mar 18, 2019
@addaleax addaleax deleted the worker-fs-watch-file branch March 18, 2019 21:25
addaleax added a commit that referenced this pull request Mar 18, 2019
Refs: #21093 (comment)

PR-URL: #21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Refs: nodejs#21093 (comment)

PR-URL: nodejs#21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
Refs: #21093 (comment)

PR-URL: #21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
Refs: #21093 (comment)

PR-URL: #21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
@addaleax
Copy link
Member Author

@BethGriggs I think this is causing failures in v10.x-staging because it depends on #26707… I think either this has to be removed or the libuv update has to be included in v10.x as well

MylesBorins pushed a commit that referenced this pull request May 16, 2019
Refs: #21093 (comment)

PR-URL: #21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants