Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,gyp: fix regex for version matching #21216

Closed
wants to merge 1 commit into from
Closed

tools,gyp: fix regex for version matching #21216

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 8, 2018 •
edited
Loading

Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

Refs: nodejs/node-gyp@293092c

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
tools,gyp: fix regex for version matching
44849eb 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

Refs: nodejs/node-gyp@293092c
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Jun 8, 2018
@Trott Trott changed the title tools: fix gyp regular expression version matching tools,gyp: fix regex for version matching Jun 8, 2018
@Trott
Copy link
Member Author

Trott commented Jun 8, 2018

@nodejs/gyp

@Trott Trott added the python PRs and issues that require attention from people who are familiar with Python. label Jun 8, 2018
bnoordhuis
bnoordhuis approved these changes Jun 8, 2018
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to fast-track, IMO.

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 8, 2018
@addaleax
Copy link
Member

addaleax commented Jun 8, 2018

CI: https://ci.nodejs.org/job/node-test-commit/19094/

@Trott
Copy link
Member Author

Trott commented Jun 8, 2018

CI: https://ci.nodejs.org/job/node-test-commit/19102/

Trott added a commit to Trott/io.js that referenced this pull request Jun 9, 2018
@Trott
tools,gyp: fix regex for version matching
a9e70d7 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: nodejs#21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented Jun 9, 2018

Landed in a9e70d7

@Trott Trott closed this Jun 9, 2018
@egoroof

This comment was marked as abuse.

Sign in to view
@Trott
Copy link
Member Author

Trott commented Jun 9, 2018

@egoroof node-gyp released the patch for this in v3.6.3 so if you're using that version or newer of node-gyp, you should be OK.

targos pushed a commit that referenced this pull request Jun 10, 2018
@Trott @targos
tools,gyp: fix regex for version matching
c09b2bb 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Trott added a commit to Trott/io.js that referenced this pull request Jun 13, 2018
@Trott
tools,gyp: fix regex for version matching
364e123 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: nodejs#21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@Trott @MylesBorins
tools,gyp: fix regex for version matching
ac85c4c 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@Trott @MylesBorins
tools,gyp: fix regex for version matching
32f4c18 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@Trott @rvagg
tools,gyp: fix regex for version matching
7a35e18 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@Trott @rvagg
tools,gyp: fix regex for version matching
c210641 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Nov 24, 2018
@Trott @rvagg
tools,gyp: fix regex for version matching
038652f 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
tools,gyp: fix regex for version matching
772fc78 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@Trott @MylesBorins
tools,gyp: fix regex for version matching
bc916e9 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
tools,gyp: fix regex for version matching
a1224ef 
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott deleted the fix-gyp branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @addaleax @egoroof @refack @bnoordhuis @richardlau @nodejs-github-bot