build: fix vcbuild merge issues #2131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure was getting called twice. We also erroneously introduced support for VS2010, and were picking 2010 before other versions.
mscdex
added
build
|
cc @nodejs/build |
|
@orangemocha we could also remove the configure step on the windows buildbots since we call project-gen regardless? |
|
LGTM FWIW |
|
@jbergstroem , yes. We are currently generating projects 3 times 😥 I will fix it. |
orangemocha
added a commit
that referenced
this pull request
Jul 10, 2015
configure was getting called twice. We also erroneously introduced support for VS2010, and were picking 2010 before other versions. PR-URL: #2131 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
Landed in 84012c9 |
|
..and removed explicit configure step from Windows jobs in Jenkins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure was getting called twice.
We also erroneously introduced support for VS2010,
and were picking 2010 before other versions.