Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update LICENSE file #21472

Closed
wants to merge 1 commit into from
Closed

doc: update LICENSE file #21472

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 22, 2018

Running license-builder.sh seems to indicate that there have been some
license changes that have not been propagated to our LICENSE file yet.
Here they are.

@richardlau

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: update LICENSE file
4c01563 
Running `license-builder.sh` seems to indicate that there have been some
license changes that have not been propagated to our LICENSE file yet.
Here they are.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/125/pipeline

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 22, 2018
@Trott
Copy link
Member Author

Trott commented Jun 22, 2018

Anybody know what's up with the http_parser license text that is removed?

@Trott Trott mentioned this pull request Jun 22, 2018
Closed
2 tasks
@bnoordhuis
Copy link
Member

@Trott nodejs/http-parser@89279ab

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 22, 2018
@Trott
Copy link
Member Author

Trott commented Jun 22, 2018

👍 here for fast-tracking.

@richardlau
Copy link
Member

Thanks for updating. Perhaps in another PR we can consider how to keep things in step, either as a test or part of the build process.

@ChALkeR
Copy link
Member

ChALkeR commented Jun 24, 2018 •
edited
Loading

@Trott is there any reason why we shouldn't be just running license-builder.sh on CI and comparing the output with LICENSE file to catch license changes in the commits that introduce those?

Will it make backporting harder?

@Trott
Copy link
Member Author

Trott commented Jun 25, 2018

@Trott is there any reason why we shouldn't be just running license-builder.sh on CI and comparing the output with LICENSE file to catch license changes in the commits that introduce those?

Seems like a good idea to me. Or write a test that does that so it can be caught during make test....

Will it make backporting harder?

I don't see how, but there could be something I'm missing.

Trott added a commit to Trott/io.js that referenced this pull request Jun 25, 2018
@Trott
doc: update LICENSE file
1e7ff81 
Running `license-builder.sh` seems to indicate that there have been some
license changes that have not been propagated to our LICENSE file yet.
Here they are.

PR-URL: nodejs#21472
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 25, 2018

Landed in 1e7ff81

@Trott Trott closed this Jun 25, 2018
@ChALkeR
Copy link
Member

ChALkeR commented Jun 25, 2018

@Trott

Or write a test that does that so it can be caught during make test.

That's what I meant :-).

targos pushed a commit that referenced this pull request Jun 25, 2018
@Trott @targos
doc: update LICENSE file
de195d5 
Running `license-builder.sh` seems to indicate that there have been some
license changes that have not been propagated to our LICENSE file yet.
Here they are.

PR-URL: #21472
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@Trott @MylesBorins
doc: update LICENSE file
12f7642 
Running `license-builder.sh` seems to indicate that there have been some
license changes that have not been propagated to our LICENSE file yet.
Here they are.

PR-URL: #21472
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
@Trott Trott deleted the license branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @bnoordhuis @richardlau @ChALkeR @jasnell @lpinca @cjihrig