Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: show options arg to new Worker is optional #21508

Closed
wants to merge 1 commit into from
Closed

doc: show options arg to new Worker is optional #21508

wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented Jun 24, 2018

Checklist

@watson watson added the worker Issues and PRs related to Worker support. label Jun 24, 2018
@nodejs-github-bot
Copy link
Collaborator

@watson build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/145/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 24, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jun 24, 2018 •
edited
Loading

Refs:

node/lib/internal/worker.js

Lines 206 to 207 in 8ab7ea6

class Worker extends EventEmitter {
constructor(filename, options = {}) {

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 24, 2018
benjamingr
benjamingr approved these changes Jun 24, 2018
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

watson added a commit that referenced this pull request Jun 24, 2018
@watson
doc: show options arg to new Worker is optional
e22d709 
PR-URL: #21508
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@watson
Copy link
Member Author

watson commented Jun 24, 2018

Landed in e22d709

@watson watson closed this Jun 24, 2018
@watson watson deleted the wt branch June 24, 2018 19:10
targos pushed a commit that referenced this pull request Jun 25, 2018
@watson @targos
doc: show options arg to new Worker is optional
dbd810e 
PR-URL: #21508
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@watson @nodejs-github-bot @vsemozhetbyt @benjamingr @targos @cjihrig @trivikr