test: add a request-response test for MessageChannel #21514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit message prefix should be |
targos
reviewed
Jun 25, 2018
test/parallel/test-message-port.js
Outdated
| const { port1, port2 } = new MessageChannel(); | ||
|
|
||
| port1.on('message', common.mustCall((message) => { | ||
| assert.strictEqual(message, 4); |
There was a problem hiding this comment.
Could port.onmessage = also be tested?
There was a problem hiding this comment.
Used it here (line 31).
Did you have something more elaborate in mind?
There was a problem hiding this comment.
I commented on the wrong line, sorry. My suggestion is to use it for both port1 and port2 (also do port1.onmessage = ...)
There was a problem hiding this comment.
Sure, why not :)
itaysabato
changed the title
benjamingr
approved these changes
Jun 25, 2018
targos
approved these changes
Jun 25, 2018
lpinca
approved these changes
Jun 25, 2018
trivikr
approved these changes
Jun 26, 2018
|
Build and test pass locally in both mac and windows. This CI failure may be a glitch... |
This commit adds a request-response test for MessageChannel. PR-URL: nodejs#21514 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
TimothyGu
approved these changes
Jun 27, 2018
benjamingr
added
the
author ready
jasnell
approved these changes
Jun 29, 2018
jasnell
pushed a commit
that referenced
this pull request
Jun 29, 2018
This commit adds a request-response test for MessageChannel. PR-URL: #21514 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 71e1602 |
targos
pushed a commit
that referenced
this pull request
Jun 30, 2018
This commit adds a request-response test for MessageChannel. PR-URL: #21514 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a request-response test for MessageChannel.
Suggested by @benjamingr and @TimothyGu here
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes