Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: remove bad fn call and check #2157

Closed
wants to merge 1 commit into from

Commits on Jul 10, 2015

  1. node: remove bad fn call and check

    These two lines exist because of a screw up on my part while combining
    MakeCallback() and MakeDomainCallback().
    
    The reason it never broke core tests is because any paths it would have
    broken were rerouted to AsyncWrap::MakeCallback(). The only case that
    node::MakeCallback() handles anymore is setImmediate().
    
    Fix: a1da024 "node, async-wrap: remove MakeDomainCallback"
    trevnorris committed Jul 10, 2015
    Configuration menu
    Copy the full SHA
    e02e296 View commit details
    Browse the repository at this point in the history