Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: fix compiler warning #21597

Merged
merged 1 commit into from
Jul 2, 2018
Merged

n-api: fix compiler warning #21597

merged 1 commit into from
Jul 2, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 29, 2018

private field 'async_context' is not used [-Wunused-private-field]

Refs: #17887

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Jun 29, 2018
@addaleax
Copy link
Member

LGTM; but: @gabrielschulhof I thought you added async context tracking? I’m not sure where that’s being propagated here…

@gabrielschulhof
Copy link
Contributor

@addaleax I believe I simply forgot to remove that field when class TsFn started inheriting from AsyncResource and therefore did no longer need to store its async_context.

@danbev
Copy link
Contributor

danbev commented Jul 2, 2018

@danbev
Copy link
Contributor

danbev commented Jul 2, 2018

node-test-commit-windows-fanned failure looks unrelated

console output:

09:30:47 not ok 566 sequential/test-inspector-break-when-eval
09:30:47   ---
09:30:47   duration_ms: 0.403
09:30:47   severity: fail
09:30:47   exitcode: 1
09:30:47   stack: |-
09:30:47     [test] Connecting to a child Node process
09:30:47     [test] Testing /json/list
09:30:47     [err] Debugger listening on ws://127.0.0.1:61103/56a876e9-c99e-4083-961c-f8ff452a4e8d
09:30:47     [err] For help, see: https://nodejs.org/en/docs/inspector
09:30:47     [err] 
09:30:47     [out] Ready!
09:30:47     [out] 
09:30:47     [test] Setting up a debugger
09:30:47     [test] Breaking in the code
09:30:47     [test] Step over console statement and test output
09:30:47     [out] 0 3
09:30:47     [out] 
09:30:47     [test] Verify node waits for the frontend to disconnect
09:30:47     [err] Debugger attached.
09:30:47     [err] Waiting for the debugger to disconnect...
09:30:47     [err] 
09:30:47     { AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
09:30:47     + expected - actual
09:30:47     
09:30:47     - 0
09:30:47     + 3221225477
09:30:47         at runTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-break-when-eval.js:65:10)
09:30:47         at process._tickCallback (internal/process/next_tick.js:68:7)
09:30:47       generatedMessage: true,
09:30:47       name: 'AssertionError [ERR_ASSERTION]',
09:30:47       code: 'ERR_ASSERTION',
09:30:47       actual: 0,
09:30:47       expected: 3221225477,
09:30:47       operator: 'strictEqual' }
09:30:47     1
09:30:47   ...

private field 'async_context' is not used [-Wunused-private-field]

PR-URL: nodejs#21597
Refs: nodejs#17887
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@cjihrig cjihrig merged commit a27b0a3 into nodejs:master Jul 2, 2018
@cjihrig cjihrig deleted the warn branch July 2, 2018 15:14
targos pushed a commit that referenced this pull request Jul 3, 2018
private field 'async_context' is not used [-Wunused-private-field]

PR-URL: #21597
Refs: #17887
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2018
private field 'async_context' is not used [-Wunused-private-field]

PR-URL: nodejs#21597
Refs: nodejs#17887
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 18, 2019
private field 'async_context' is not used [-Wunused-private-field]

PR-URL: #21597
Refs: #17887
Backport-PR-URL: #25002
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
private field 'async_context' is not used [-Wunused-private-field]

PR-URL: #21597
Refs: #17887
Backport-PR-URL: #25002
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants