Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x] src: add convenience ctor for async trigger id scope #21600

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This backport differs from the original only in the
omission of a change to stream_base-inl.h which
would have generated conflicts.

PR-URL: #19204

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This backport differs from the original only in the
omission of a change to `stream_base-inl.h` which
would have generated conflicts.

PR-URL: nodejs#19204
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Jun 30, 2018
MylesBorins pushed a commit that referenced this pull request Jul 13, 2018
This backport differs from the original only in the
omission of a change to `stream_base-inl.h` which
would have generated conflicts.

Backport-PR-URL: #21600
PR-URL: #19204
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 0d41b02

rvagg pushed a commit that referenced this pull request Aug 16, 2018
This backport differs from the original only in the
omission of a change to `stream_base-inl.h` which
would have generated conflicts.

Backport-PR-URL: #21600
PR-URL: #19204
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants