doc: fix some typos in N-API docs #21614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
vsemozhetbyt
added
errors
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
starkwang
approved these changes
Jul 1, 2018
vsemozhetbyt
added
the
author ready
cjihrig
approved these changes
Jul 1, 2018
hiroppy
approved these changes
Jul 1, 2018
Trott
reviewed
Jul 1, 2018
doc/api/n-api.md
Outdated
| @@ -4093,7 +4093,7 @@ added: REPLACEME | |||
| ```C | |||
| NAPI_EXTERN napi_status | |||
| napi_get_threadsafe_function_context(napi_threadsafe_function func, | |||
| void** result); | |||
| void** context); | |||
There was a problem hiding this comment.
It's restuls and not context in the source code (src/node_api.h and src/node_api.cc). Those should be updated to match as well?
There was a problem hiding this comment.
If so, please, anybody familiar with C++, push a commit in this PR or suggest a diff. I am afraid to break something)
There was a problem hiding this comment.
@vsemozhetbyt just keep result, it matches with the signature in src/node_api.h.
There was a problem hiding this comment.
Should I replace context with result then in options below so that the signature matches options?
lpinca
approved these changes
Jul 1, 2018
trivikr
approved these changes
Jul 1, 2018
vsemozhetbyt
added
the
fast-track
|
Landed in 484c6c3 |
vsemozhetbyt
added a commit
that referenced
this pull request
Jul 1, 2018
PR-URL: #21614 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 3, 2018
PR-URL: #21614 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes