Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use https://nodejs.org URL when possible. #21719

Closed
wants to merge 1 commit into from
Closed

Use https://nodejs.org URL when possible. #21719

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jul 9, 2018

No description provided.

@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Jul 9, 2018
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jul 9, 2018 •
edited
Loading

BTW I searched the code base for http: and there are hundreds if not thousands of http links that could be changed, but I thought I'd leave this for someone else :)

ChALkeR
ChALkeR approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

On a side note, these might also need updating:

tools/pkgsrc/description:7:http://nodejs.org/
tools/rpm/node.spec:25:Source0: http://nodejs.org/dist/v%{_version}/node-v%{_version}.tar.gz
src/string_bytes.cc:346:      // http://nodejs.org/api/buffer.html regarding Node's "ucs2"
src/string_bytes.cc:712:  // http://nodejs.org/api/buffer.html regarding Node's "ucs2"
src/node_buffer.cc:486:  // need to reorder on BE platforms.  See http://nodejs.org/api/buffer.html

@XhmikosR

hundreds if not thousands of http links

Everything in node_modules and deps (and other thirdparty code locations) should be excluded.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jul 10, 2018 •
edited
Loading

@ChALkeR: I know but I didn't only search for http://nodejs.org. I searched for http: excluding the valid http links like the SVG one and there are still quite many.

I could have a stab at it later but I think the best would be if this would be split up in parts.

For starters I could replace all nodejs.org links if you guys want in this PR.

@XhmikosR
Copy link
Contributor Author

Done. I changed all the http://nodejs.org references except for http.md and tests/bench.

@XhmikosR XhmikosR changed the title Windows Start Menu shortcut: Use the https URL. Use https://nodejs.org URL when possible. Jul 10, 2018
@XhmikosR XhmikosR mentioned this pull request Jul 11, 2018
Merged
@jasnell
Copy link
Member

jasnell commented Jul 12, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15828/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 13, 2018
@addaleax
Copy link
Member

AIX CI re-run: https://ci.nodejs.org/job/node-test-commit-aix/16304/

@addaleax
Copy link
Member

addaleax commented Jul 14, 2018 •
edited
Loading

Landed in 998f9ff 🎉

@addaleax addaleax closed this Jul 14, 2018
addaleax pushed a commit that referenced this pull request Jul 14, 2018
@XhmikosR @addaleax
src,tools: use https://nodejs.org URL when possible.
998f9ff 
PR-URL: #21719
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Jul 14, 2018
@XhmikosR @targos
src,tools: use https://nodejs.org URL when possible.
aa5994f 
PR-URL: #21719
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
This was referenced Jul 18, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.