tools: avoid global install of dmn for lint update #21744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating ESLint, use npx to run dmn rather than installing dmn globally.
|
(Lite CI should be sufficient as the shell script is not run or even analyzed in CI.) |
silverwind
approved these changes
Jul 11, 2018
targos
approved these changes
Jul 11, 2018
lpinca
approved these changes
Jul 11, 2018
jasnell
approved these changes
Jul 11, 2018
TimothyGu
approved these changes
Jul 11, 2018
cjihrig
approved these changes
Jul 12, 2018
BridgeAR
approved these changes
Jul 12, 2018
BridgeAR
added
the
author ready
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 13, 2018
When updating ESLint, use npx to run dmn rather than installing dmn globally. PR-URL: nodejs#21744 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 19bc893 |
targos
pushed a commit
that referenced
this pull request
Jul 14, 2018
When updating ESLint, use npx to run dmn rather than installing dmn globally. PR-URL: #21744 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating ESLint, use npx to run dmn rather than installing dmn
globally.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes