Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-gyp: support for Chromium versions of Python #21790

Closed
wants to merge 1 commit into from

Conversation

hashseed
Copy link
Member

V8's test infrastructure uses a particular brand of Python. We have been floating this fix on our Node.js branch for quite a while. I am hoping that we can land this upstream too.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Jul 13, 2018
This works around a Python version string particular to
V8 test infrastructure.
@richardlau
Copy link
Member

This should be upstreamed to https://github.com/nodejs/node-gyp otherwise it's likely to be lost on npm updates.

@Trott
Copy link
Member

Trott commented Jul 13, 2018

Whether floating the patch here or upstreaming, might it be better to replace the code block added in this PR and the two similar indexOf()/.replace() things above with something like this (untested) block?:

var matches = version.match(/(\d+\.\d+\.\d+)/);
if (!matches) {
  return this.callback(new Error('unexpected version string format: ' + version));
}
if (version !== matches[0]) {
  this.log.silly('stripping characters from version: "' + version + '" -> "' + matches[0] + '"');
  version = matches[0];
}

@Trott
Copy link
Member

Trott commented Jul 13, 2018

@nodejs/node-gyp

@hashseed
Copy link
Member Author

I created a PR for nodejs/node-gyp.

@hashseed hashseed closed this Jul 17, 2018
@hashseed hashseed deleted the chromiumpython branch November 20, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants