test: add gc tracking API to common, refactor pummel net test + move it to parallel #21794
Conversation
This enables the test to run as part of the regular test suite.
|
Any chance these changes also apply to the other two memleak tests in pummel? ( Also, we should probably run a stress test just to make sure we're not introducing unreliable tests into the |
This enables the test to run as part of the regular test suite.
Yes – not sure about the VM test but the TLS one is definitely of the same kind. Added a similar commit for the TLS test :)
Locally, all 3 tests happily pass Regular CI: https://ci.nodejs.org/job/node-test-pull-request/15859/ |
test/common/README.md
Outdated
| @@ -326,6 +326,21 @@ See `common.expectWarning()` for usage. | |||
|
|
|||
| Indicates whether 'opensslCli' is supported. | |||
|
|
|||
| ### onGC(target, listener) | |||
There was a problem hiding this comment.
Should this section go before the opensslCli(), ABC-wise?
test/common/README.md
Outdated
| ### onGC(target, listener) | ||
| * `target` [<Object>] | ||
| * `listener` [<Object>] | ||
| * `listener.ongc` [<Function>] |
There was a problem hiding this comment.
`listener.ongc` -> `ongc` for consistency with other doc cases?
test/common/README.md
Outdated
| a full `setImmediate()` invocation passes. | ||
|
|
||
| `listener` is an object to make it easier to use a closure; the target object | ||
| should not be in scope when `listener.ongc` is created. |
There was a problem hiding this comment.
`listener.ongc` -> `listener.ongc()`?
|
@vsemozhetbyt Thanks, done in 24bd33b :) |
|
Landed in d94950e...9a34c5b |
PR-URL: #21794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This enables the test to run as part of the regular test suite. PR-URL: #21794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This enables the test to run as part of the regular test suite. PR-URL: #21794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #21794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This enables the test to run as part of the regular test suite. PR-URL: #21794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This enables the test to run as part of the regular test suite. PR-URL: #21794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes