test: pass through stderr in benchmark tests #21860
Conversation
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure).
|
@addaleax - why is the third entry (in the stdio array) required? |
|
@gireeshpunathil I’m not sure I understand – the first one is for stdin, which we don’t really care about, the second one is for stdout (which is what we’re testing here, so we need to capture it). The third one is for stderr; that’s the debugging information that should not get lost in the parent process. The fourth one is necessary for |
|
my apologies - I meant the 4th entry (somehow the 0 based index concept messed up with the natural language).
Can you please elaborate? missing to catch this. Is it for |
|
@gireeshpunathil I think I think we might be able to switch to another |
addaleax
added
the
author ready
|
Just fixed AIX in CI (I hope): https://ci.nodejs.org/job/node-test-pull-request/16049/ |
|
Landed in 8a62cdb |
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure). PR-URL: #21860 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure). PR-URL: #21860 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This helps a lot with debugging failing benchmark tests,
which would otherwise just print an assertion for the
exit code (something like
+1 -0, which yields almost noinformation about a failure).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes