Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: enable no-extra-semi rule in the linter #2207

Closed
wants to merge 2 commits into from

Conversation

silverwind
Copy link
Contributor

The no-extra-semi rule was requested multiple times, so here it is:

The big issue here were bodyless while and for loops. I took the time to refactor two cases in lib to hopefully be more readable. There were a few cases in test that do things like call a function until it returns false, where I opted to just put an empty body with a comment. If these are too ugly, we can wait on eslint/eslint#3075 for a fix.

cc: @targos

@silverwind silverwind added the tools Issues and PRs related to the tools directory. label Jul 19, 2015
This rule ensures that no unnecessary semicolon after function
declarations is allowed, e.g. this will error:

function x() {
  // code
};
@silverwind silverwind changed the title tools: enable semicolon rules in linter tools: enable no-extra-semi rule in the linter Jul 19, 2015
@silverwind
Copy link
Contributor Author

Updated to only include a single rule. @targos I'll close this if you like so we can collaborate on #2205.

@silverwind
Copy link
Contributor Author

Decided to close this one in favor of #2205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant