Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix a problem that the test fails at the windows7 command prompt #22102

Closed
wants to merge 1 commit into from
Closed

test: fix a problem that the test fails at the windows7 command prompt #22102

wants to merge 1 commit into from

Conversation

briete
Copy link
Contributor

@briete briete commented Aug 3, 2018

When testing with 'cmd.exe' of Windows 7,
'spawn cat ENOENT' error has occurred.
Since the standard 'cmd.exe' has no 'cat' command,
Instead will use the 'type' command

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

When testing with 'cmd.exe' of Windows 7,
'spawn cat ENOENT' error has occurred.
Since the standard 'cmd.exe' has no 'cat' command,
Instead will use the 'type' command
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 3, 2018
@hiroppy hiroppy added http Issues or PRs related to the http subsystem. wsl Issues and PRs related to the Windows Subsystem for Linux. windows Issues and PRs related to the Windows platform. and removed wsl Issues and PRs related to the Windows Subsystem for Linux. labels Aug 3, 2018
@richardlau
Copy link
Member

cc @nodejs/platform-windows

We used to have common.spawnCat which had Windows specific logic to avoid cat, but this was removed in #11953.

This is not the only test to use cat, e.g. test/parallel/test-child-process-stdio.js. We do require basic Unix tools on Windows for tests, https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1:

  • Basic Unix tools required for some tests, Git for Windows includes Git Bash and tools which can be included in the global PATH.

@briete
Copy link
Contributor Author

briete commented Aug 5, 2018

@richardlau
Thank you for review.
To build and test Node.js on Windows, use UNIX tools.

@BridgeAR
Copy link
Member

BridgeAR commented Sep 5, 2018

If I understand the comments correct, this should be closed. @briete thanks for your contribution!

If this is closed by mistake, please reopen or leave a comment to ask that this should be reopened.

@BridgeAR BridgeAR closed this Sep 5, 2018
@briete
Copy link
Contributor Author

briete commented Sep 7, 2018

@BridgeAR I'm sorry. understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants