Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: Remove useless parameters #22115

Closed
wants to merge 1 commit into from
Closed

zlib: Remove useless parameters #22115

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 4, 2018

When checkRangesOrGetDefault calls checkFiniteNumber, the latter
function only has two parameters, so lower and upper don't need to
be passed for validation.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows [commit guidelines

When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter
function only has two parameters, so `lower` and `upper` don't need to
be passed for validation.
@nodejs-github-bot nodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Aug 4, 2018
@Trott
Copy link
Member

Trott commented Aug 4, 2018

@ghost
Copy link
Author

ghost commented Aug 4, 2018

@Trott:Another of my submit has also met with the same problem, that CI's test commit failed: #21906.

@Trott
Copy link
Member

Trott commented Aug 6, 2018

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 7, 2018
@trivikr
Copy link
Member

trivikr commented Aug 7, 2018

Trott pushed a commit to Trott/io.js that referenced this pull request Aug 7, 2018
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter
function only has two parameters, so `lower` and `upper` don't need to
be passed for validation.

PR-URL: nodejs#22115
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 7, 2018

Landed in 493e6d4

@Trott Trott closed this Aug 7, 2018
@ghost ghost deleted the zlibUselessParams branch August 8, 2018 00:43
@ghost
Copy link
Author

ghost commented Aug 8, 2018

Thanks!

targos pushed a commit that referenced this pull request Aug 11, 2018

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter
function only has two parameters, so `lower` and `upper` don't need to
be passed for validation.

PR-URL: #22115
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants