Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: test: remove common.fileExists() #22200

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

test-trace-event-promises.js was added to the codebase between the last
CI for #22151 and it landing.

Refs: #22151

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test-trace-event-promises.js was added to the codebase between the last
CI for nodejs#22151 and it landing.

Refs: nodejs#22151
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 8, 2018
@richardlau richardlau mentioned this pull request Aug 8, 2018
3 tasks
@richardlau
Copy link
Member Author

cc @Trott @vsemozhetbyt

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 8, 2018
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjamn
Copy link
Contributor

benjamn commented Aug 8, 2018

@MylesBorins
Copy link
Contributor

landed in d7e1847

@MylesBorins MylesBorins closed this Aug 8, 2018
MylesBorins pushed a commit that referenced this pull request Aug 8, 2018
test-trace-event-promises.js was added to the codebase between the last
CI for #22151 and it landing.

PR-URL: #22200
Refs: #22151
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@Trott
Copy link
Member

Trott commented Aug 8, 2018

@richardlau Thanks for fixing my misstep!

targos pushed a commit that referenced this pull request Aug 11, 2018
test-trace-event-promises.js was added to the codebase between the last
CI for #22151 and it landing.

PR-URL: #22200
Refs: #22151
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.