tls: refactor variable declarations #22219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Aug 9, 2018
jasnell
approved these changes
Aug 9, 2018
Trott
added
the
author ready
cjihrig
approved these changes
Aug 9, 2018
trivikr
approved these changes
Aug 12, 2018
devsnek
approved these changes
Aug 12, 2018
aduh95
reviewed
Aug 12, 2018
| var out = Object.create(null); | ||
| var parts = s.split('\n'); | ||
| const out = Object.create(null); | ||
| const parts = s.split('\n'); | ||
| for (var i = 0, len = parts.length; i < len; i++) { |
There was a problem hiding this comment.
Shouldn't we replace the for loop by a for-of loop?
There was a problem hiding this comment.
Using the traditional for loop is still significantly faster than for-of and is fairly idiomatic still within Node.js core js.
maclover7
approved these changes
Aug 12, 2018
jasnell
pushed a commit
that referenced
this pull request
Aug 12, 2018
PR-URL: #22219 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jon Moss <me@jonathanmoss.me>
|
Landed in 74d3363 |
rvagg
pushed a commit
that referenced
this pull request
Aug 13, 2018
PR-URL: #22219 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jon Moss <me@jonathanmoss.me>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change var to const
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes