src: add READONLY_STRING_PROPERTY and simplify config #22222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bit of tidying up where we set different config values..
nodejs-github-bot
added
the
c++
richardlau
approved these changes
Aug 9, 2018
addaleax
approved these changes
Aug 9, 2018
src/node_config.cc
Outdated
| @@ -29,6 +29,18 @@ using v8::Value; | |||
| True(isolate), ReadOnly).FromJust(); \ | |||
| } while (0) | |||
|
|
|||
| #define READONLY_STRING_PROPERTY(obj, str, val) \ | |||
| do { \ | |||
| obj->DefineOwnProperty(context, \ | |||
There was a problem hiding this comment.
It’s a best practice to parenthesize macro parameters, i.e. use (obj)->DefineOwnProperty(…), even if this is probably not an issue for now :)
src/node_config.cc
Outdated
| String::NewFromUtf8( \ | ||
| isolate, \ | ||
| val.data(), \ | ||
| v8::NewStringType::kNormal).ToLocalChecked(), \ |
There was a problem hiding this comment.
tiny nit: 4 spaces for statement continuations
cjihrig
approved these changes
Aug 10, 2018
devsnek
approved these changes
Aug 10, 2018
jasnell
approved these changes
Aug 11, 2018
maclover7
added
the
author ready
|
Landed in 30b5b84 |
maclover7
added a commit
that referenced
this pull request
Aug 12, 2018
Bit of tidying up where we set different config values. PR-URL: #22222 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 12, 2018
Bit of tidying up where we set different config values. PR-URL: #22222 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of tidying up where we set different config values.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes