util,assert: fix boxed primitives bug #22243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the comparison could throw an error in case a boxed primitive has no valueOf function on one side of the assert call.
nodejs-github-bot
added
the
util
lpinca
approved these changes
Aug 10, 2018
BridgeAR
added
the
author ready
|
Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16379/ |
trivikr
approved these changes
Aug 12, 2018
gdams
approved these changes
Aug 12, 2018
|
landed in: c7ca199 |
gdams
pushed a commit
that referenced
this pull request
Aug 12, 2018
Currently the comparison could throw an error in case a boxed primitive has no valueOf function on one side of the assert call. PR-URL: #22243 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
rvagg
pushed a commit
that referenced
this pull request
Aug 13, 2018
Currently the comparison could throw an error in case a boxed primitive has no valueOf function on one side of the assert call. PR-URL: #22243 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes