Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: fix not return on error #2225

Closed
wants to merge 1 commit into from
Closed

buffer: fix not return on error #2225

wants to merge 1 commit into from

Commits on Jul 22, 2015

  1. buffer: fix not return on error 

    Throwing a JS error from C++ does not mean the function will return
early. This must be done manually.

Also remove extraneous comment no longer relevant.

Fix: 2903030 "buffer: switch API to return MaybeLocal<T>"
    @trevnorris
    trevnorris committed Jul 22, 2015
    Configuration menu
    Copy the full SHA
    30ad7f5 View commit details
    Browse the repository at this point in the history