Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Remove unused param for exec in child_process #22274

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: Remove unused param for exec in child_process
`exec`'s parameters are now deconstructored through
`normalizeExecArgs.apply`. We don't need an exclipit parameter
any more (and in fact it's NEVER referred in the code directly), like `spwan` or `spwanSync`.
This might be missing.
MaleDong committed Aug 12, 2018
commit 6c7b8b95b7d68025fa68eff99b1ac84894b0ac4c
4 changes: 2 additions & 2 deletions lib/child_process.js
Original file line number Diff line number Diff line change
@@ -142,8 +142,8 @@ function normalizeExecArgs(command, options, callback) {
}


exports.exec = function exec(command /* , options, callback */) {
var opts = normalizeExecArgs.apply(null, arguments);
exports.exec = function exec(/* command , options, callback */) {
const opts = normalizeExecArgs.apply(null, arguments);
return exports.execFile(opts.file,
opts.options,
opts.callback);