util: fix sparse array inspection #22283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For very special sparse arrays it was possible that util.inspect visualized the entries not in the intended way.
nodejs-github-bot
added
the
util
jasnell
approved these changes
Aug 12, 2018
trivikr
approved these changes
Aug 12, 2018
BridgeAR
added
the
author ready
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Aug 15, 2018
For very special sparse arrays it was possible that util.inspect visualized the entries not in the intended way. PR-URL: nodejs#22283 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in 6bba368 🎉 |
targos
pushed a commit
that referenced
this pull request
Aug 19, 2018
For very special sparse arrays it was possible that util.inspect visualized the entries not in the intended way. PR-URL: #22283 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
For very special sparse arrays it was possible that util.inspect visualized the entries not in the intended way. PR-URL: #22283 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For very special sparse arrays it was possible that util.inspect
visualized the entries not in the intended way.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes