Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: mark special entries as such #22287

Closed
wants to merge 1 commit into from
Closed

util: mark special entries as such #22287

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This adds the color code to special entries if colors are active.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/538/pipeline

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Aug 12, 2018
@BridgeAR BridgeAR force-pushed the mark-inspect-special branch 2 times, most recently from f766ef3 to b361417 Compare August 13, 2018 00:07
@BridgeAR
Copy link
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/16403/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 13, 2018
lpinca
lpinca reviewed Aug 13, 2018
View reviewed changes
test/parallel/test-util-inspect.js Outdated
`WeakSet { \u001b[${special[0]}m<items unknown>\u001b[${special[1]}m }`
);
assert.strictEqual(
inspect(new WeakSet(), { colors: true }),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this assertion repeated on purpose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing author ready label because of this open question

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Copy paste error :) It's now resolved.

@trivikr trivikr removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 14, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 14, 2018
@BridgeAR
Copy link
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/16464/

@BridgeAR
Copy link
Member Author

Rebased due to conflicts.

CI https://ci.nodejs.org/job/node-test-pull-request/16466/

This was referenced Aug 17, 2018
Closed
Closed
@BridgeAR
util: mark special entries as such
2988330 
This adds the color code to special entries if colors are active.
@BridgeAR
Copy link
Member Author

BridgeAR commented Aug 19, 2018 •
edited
Loading

Rebased again due to conflicts.

CI https://ci.nodejs.org/job/node-test-pull-request/16569/ ✔️

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 19, 2018
@BridgeAR
util: mark special entries as such
bd090f9 
This adds the color code to special entries if colors are active.

PR-URL: nodejs#22287
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR
Copy link
Member Author

Landed in bd090f9 🎉

@BridgeAR BridgeAR closed this Aug 19, 2018
@targos targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 19, 2018
@targos
Copy link
Member

targos commented Aug 19, 2018

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@targos
Copy link
Member

targos commented Aug 19, 2018

Landed easily after #21869

targos pushed a commit that referenced this pull request Aug 19, 2018
@BridgeAR @targos
util: mark special entries as such
f5341f0 
This adds the color code to special entries if colors are active.

PR-URL: #22287
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@BridgeAR @targos
util: mark special entries as such
1828017 
This adds the color code to special entries if colors are active.

PR-URL: #22287
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
This was referenced Sep 6, 2018
Closed
Closed
@BridgeAR BridgeAR deleted the mark-inspect-special branch January 20, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@devsnek devsnek devsnek approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BridgeAR @nodejs-github-bot @targos @jasnell @lpinca @devsnek @trivikr