Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: cherry-pick 9a23bdd from upstream V8 #22338

Closed
wants to merge 1 commit into from
Closed

deps: cherry-pick 9a23bdd from upstream V8 #22338

wants to merge 1 commit into from

Conversation

Drieger
Copy link
Contributor

@Drieger Drieger commented Aug 15, 2018

Original commit message:

[Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames

Previously we were getting the code object from the stack, so printed incorrect
position details for interpreted frames.

BUG=v8:7916

Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
Reviewed-on: https://chromium-review.googlesource.com/1126313
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54253}

Refs: v8/v8@9a23bdd
Fixes: #21988

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Aug 15, 2018
@mmarchini
Copy link
Contributor

mmarchini commented Aug 15, 2018 •
edited
Loading

@nodejs/v8 @nodejs/v8-update PTAL. Is there any chance we can backport this upstream to 6.8?

@ofrobots
Copy link
Contributor

The process to request an merge to an active upstream upstream branch is documented here.

Specifically:

  • Find the V8 bug corresponding to the patch: https://bugs.chromium.org/p/v8/issues/detail?id=7916 in this case.
  • Attach the merge request label: merge-request-6.8 in this case. Specify the why it is needed and link to the Node.js issue here.
  • Add ofrobots-at-google.com to the cc list.

I've gone ahead and done the above.

@Drieger Drieger mentioned this pull request Aug 20, 2018
Closed
@Drieger
deps: cherry-pick 9a23bdd from upstream V8
8b7def0 
Original commit message:

    [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames

    Previously we were getting the code object from the stack, so printed incorrect
    position details for interpreted frames.

    BUG=v8:7916

    Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
    Reviewed-on: https://chromium-review.googlesource.com/1126313
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#54253}

Refs: v8/v8@9a23bdd
Fixes: nodejs#21988
@Drieger
Copy link
Contributor Author

Drieger commented Sep 10, 2018

Commit has landed in 6.9

@Drieger Drieger closed this Sep 10, 2018
BethGriggs pushed a commit that referenced this pull request Oct 2, 2018
@Drieger @BethGriggs
deps: backport 9a23bdd from upstream V8
9e2077a 
Original commit message:

    [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames

    Previously we were getting the code object from the stack, so printed incorrect
    position details for interpreted frames.

    BUG=v8:7916

    Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
    Reviewed-on: https://chromium-review.googlesource.com/1126313
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54253}

Refs: v8/v8@9a23bdd
Fixes: #21988

PR-URL: #22418
Refs: #22338
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmarchini mmarchini mmarchini approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing stack trace when using --abort-on-uncaught-exception
4 participants
@Drieger @mmarchini @ofrobots @nodejs-github-bot