Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 6.4.0 #22342

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 6.4.0 #22342

wants to merge 1 commit into from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Aug 15, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Where this should land
  • Node 10
  • Node 8
Notable Changes

This release includes two versions of npm, including the current latest release, npm@6.4.0.

  • f861c2b57 node-gyp@3.8.0: This means our entire npm dep tree now uses the latest node-gyp, and we've updated and flattened request as well. npm audit on npm itself comes up clean now! (@rvagg)

  • 6e9f04b0b npm/cli#8 Search for authentication token defined by environment variables by preventing the translation layer from env variable to npm option from breaking :_authToken. (@mkhl)

  • 84bfd23e7 npm/cli#35 Stop filtering out non-IPv4 addresses from local-addrs, making npm actually use IPv6 addresses when it must. (@valentin2105)

  • d81146181 npm/cli#32 Don't check for updates to npm when we are updating npm itself. (@olore)

  • Another reminder that we've moved our issue tracking! You can read more about our move away from GitHub for issue tracking on our blog

Changelogs

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Aug 15, 2018
@brodycj
Copy link

brodycj commented Aug 15, 2018

I would like to thank @zkat, @rvagg, and others for the dedication behind this nice update. I suspect you already know that we will have to wait a couple weeks for this one to land ref:

@zkat
Copy link
Contributor Author

zkat commented Aug 16, 2018

Yes, I'm aware of the policy, seeing as I was part of the discussion for it. :)

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@joyeecheung
Copy link
Member

This PR needs a rebase against master to avoid the git failure in the CI.

@BridgeAR
Copy link
Member

@joyeecheung would it not be sufficient to rebase on the CI task?

@zkat
Copy link
Contributor Author

zkat commented Aug 22, 2018

I've rebased it 👍

@zkat zkat mentioned this pull request Aug 29, 2018
4 tasks
@zkat
Copy link
Contributor Author

zkat commented Aug 29, 2018

Moving this to #22591, since 6.4.1 came out in the meantime 😅

@zkat zkat closed this Aug 29, 2018
@brodycj
Copy link

brodycj commented Aug 29, 2018

Doesn't that mean we have to wait another 2 weeks to get npm@6.4.x integrated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants