test: remove third argument from assert.strictEqual() #22371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Aug 17, 2018
lpinca
approved these changes
Aug 17, 2018
trivikr
added
the
author ready
trivikr
approved these changes
Aug 18, 2018
maclover7
approved these changes
Aug 18, 2018
Trott
approved these changes
Aug 18, 2018
`test/parallel/test-util-inspect.js` has a call to `assert.strictEqual()` that receives three arguments. The third argument is a string literal. Unfortunately, calling assert.strictEqual() this way means that if there is an AssertionError, the value of the variables pos and npos are not reported. This PR removes this argument.
Trott
force-pushed
the
assert.StrictEqual-remove-third-argument
branch
from
b2bd7a2
to
9b2fbe2
Compare
|
This PR needs a rebase against master to avoid the git failure in the CI. |
This was referenced Aug 20, 2018
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/16592/ |
gdams
approved these changes
Aug 20, 2018
|
landed in: f1d3f97. Thanks for the PR @diprudnikov! |
gdams
pushed a commit
that referenced
this pull request
Aug 20, 2018
`test/parallel/test-util-inspect.js` has a call to `assert.strictEqual()` that receives three arguments. The third argument is a string literal. Unfortunately, calling assert.strictEqual() this way means that if there is an AssertionError, the value of the variables pos and npos are not reported. This PR removes this argument. PR-URL: #22371 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Aug 21, 2018
`test/parallel/test-util-inspect.js` has a call to `assert.strictEqual()` that receives three arguments. The third argument is a string literal. Unfortunately, calling assert.strictEqual() this way means that if there is an AssertionError, the value of the variables pos and npos are not reported. This PR removes this argument. PR-URL: #22371 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
`test/parallel/test-util-inspect.js` has a call to `assert.strictEqual()` that receives three arguments. The third argument is a string literal. Unfortunately, calling assert.strictEqual() this way means that if there is an AssertionError, the value of the variables pos and npos are not reported. This PR removes this argument. PR-URL: #22371 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/parallel/test-util-inspect.jshas a call toassert.strictEqual()that receives three arguments.The third argument is a string literal. Unfortunately,
calling assert.strictEqual() this way means that if
there is an AssertionError, the value of the variables
pos and npos are not reported.
This PR removes this argument.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes