test: harden test-gc-http-client #22373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
force-pushed
the
harden-gc-test
branch
from
1ed6fde
to
c561609
Compare
|
My local test: |
|
stress test: https://ci.nodejs.org/job/node-stress-single-test/1993/ ✔️ |
|
The stress test came out green. |
This was referenced Aug 17, 2018
joyeecheung
approved these changes
Aug 17, 2018
test/parallel/test-gc-http-client.js
Outdated
| let done = 0; | ||
| let count = 0; | ||
| let countGC = 0; | ||
|
|
||
| console.log(`We should do ${todo} requests`); | ||
|
|
||
| const server = http.createServer(serverHandler); | ||
| server.listen(0, getall); | ||
|
|
||
| server.listen(0, () => { |
There was a problem hiding this comment.
Can you wrap this in common.mustCall()?
There was a problem hiding this comment.
We have lots of tests that make sure that server.listen triggers the callback. If that would not hold, hundreds of tests would fail but if you think strongly about it, I'm going to add it.
There was a problem hiding this comment.
@BridgeAR I don't feel strongly about it :)
lpinca
approved these changes
Aug 18, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
Aug 19, 2018
|
I wrapped the listen call in a mustCall now. New CI https://ci.nodejs.org/job/node-test-pull-request/16567/ |
|
Resumed build https://ci.nodejs.org/job/node-test-pull-request/16572/ |
|
@BridgeAR This needs to be rebased against master to bypass an unfortunate quirk of CI that's affecting some PRs. |
This reduces the total number of requests from 500 to 300 and triggers more requests in parallel. It also moves some function creation out and waits with the first request until the server is listening. Fixes: nodejs#22336
BridgeAR
force-pushed
the
harden-gc-test
branch
from
b968c26
to
262fc9f
Compare
|
CI is green |
|
Landed in 79642ae, thanks! |
joyeecheung
pushed a commit
that referenced
this pull request
Aug 20, 2018
This reduces the total number of requests from 500 to 300 and triggers more requests in parallel. It also moves some function creation out and waits with the first request until the server is listening. PR-URL: #22373 Fixes: #22336 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 21, 2018
This reduces the total number of requests from 500 to 300 and triggers more requests in parallel. It also moves some function creation out and waits with the first request until the server is listening. PR-URL: #22373 Fixes: #22336 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
This reduces the total number of requests from 500 to 300 and triggers more requests in parallel. It also moves some function creation out and waits with the first request until the server is listening. PR-URL: #22373 Fixes: #22336 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the total number of requests from 500 to 300 and triggers
more requests in parallel. It also moves some function creation out
and waits with the first request until the server is listening.
Fixes: #22336
@nodejs/testing PTAL
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes