src: implement v8::Platform::CallDelayedOnWorkerThread #22383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
devsnek
approved these changes
Aug 18, 2018
addaleax
approved these changes
Aug 18, 2018
src/node_platform.cc
Outdated
| std::unique_ptr<Task> TakeTimerTask(uv_timer_t* timer) { | ||
| std::unique_ptr<Task> task(static_cast<Task*>(timer->data)); | ||
| uv_timer_stop(timer); | ||
| uv_close(reinterpret_cast<uv_handle_t*>(timer), [](uv_handle_t* handle) {}); |
There was a problem hiding this comment.
Shouldn’t the close callback free the memory allocated for handle here? Or, alternatively …
src/node_platform.cc
Outdated
| TaskQueue<v8::Task> tasks_; | ||
| uv_loop_t loop_; | ||
| uv_async_t flush_tasks_; | ||
| std::set<uv_timer_t*> timers_; |
There was a problem hiding this comment.
… I think we could use the fact that std::set comes with retaining referential integrity in the presence of insert/erase operations, so we could avoid the double allocations and use std::set<uv_timer_t> instead, right? (If not: I don’t think there’s an advantage over std::unordered_set, right?)
There was a problem hiding this comment.
Explicit allocation looks simpler to me, so I replaced set with unordered_set. Thank you!
src/node_platform.cc
Outdated
|
|
||
| static void RunTask(uv_timer_t* timer) { | ||
| DelayedTaskScheduler* scheduler = | ||
| static_cast<DelayedTaskScheduler*>(timer->loop->data); |
There was a problem hiding this comment.
Nit: scheduler = ContainerOf(&DelayedTaskScheduler::loop_, timer->loop);
addaleax
added
the
author ready
jasnell
approved these changes
Aug 19, 2018
|
This PR needs a rebase against master to avoid the git failure in the CI. |
|
I rebased and restarted CI: https://ci.nodejs.org/job/node-test-pull-request/16589/ |
This method is crucial for Runtime.evaluate protocol command with timeout flag. At least Chrome DevTools frontend uses this method for every execution in console. Fixes: #22157
|
Landed in b1e2612 |
alexkozy
added a commit
that referenced
this pull request
Aug 21, 2018
This method is crucial for Runtime.evaluate protocol command with timeout flag. At least Chrome DevTools frontend uses this method for every execution in console. PR-URL: #22383 Fixes: #22157 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@ak239 Can you open a backport PR against |
3 tasks
|
I uploaded rebased PR and started CI there, I won't have internet connection next 12 hours, so I would appreciate help with merging my backport, thanks ahead! |
addaleax
pushed a commit
that referenced
this pull request
Aug 28, 2018
This method is crucial for Runtime.evaluate protocol command with timeout flag. At least Chrome DevTools frontend uses this method for every execution in console. Backport-PR-URL: #22567 PR-URL: #22383 Fixes: #22157 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
removed
the
author ready
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
This method is crucial for Runtime.evaluate protocol command with timeout flag. At least Chrome DevTools frontend uses this method for every execution in console. Backport-PR-URL: #22567 PR-URL: #22383 Fixes: #22157 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
This method is crucial for Runtime.evaluate protocol command with timeout flag. At least Chrome DevTools frontend uses this method for every execution in console. Backport-PR-URL: #22567 PR-URL: #22383 Fixes: #22157 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Sep 6, 2018
blattersturm
pushed a commit
to citizenfx/node
that referenced
this pull request
Nov 3, 2018
This method is crucial for Runtime.evaluate protocol command with timeout flag. At least Chrome DevTools frontend uses this method for every execution in console. PR-URL: nodejs#22383 Fixes: nodejs#22157 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added
the
v8 platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is crucial for Runtime.evaluate protocol command with
timeout flag. At least Chrome DevTools frontend uses this flag for
every execution in console.
Fixes: #22157
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes