Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: unify optional arguments format in headings #22397

Closed
wants to merge 1 commit into from
Closed

doc: unify optional arguments format in headings #22397

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Make space and comma distribution in some headings consistent with the majority of headings.

Make space and comma distribution in some headings
consistent with the majority of headings.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 19, 2018
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 19, 2018
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably use remark-lint to catch any reintroduction of this sort of thing.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 19, 2018
@vsemozhetbyt
Copy link
Contributor Author

Landed in 14e6274
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the doc-fix-spaces-in-headings branch August 19, 2018 18:47
vsemozhetbyt added a commit that referenced this pull request Aug 19, 2018
Make space and comma distribution in some headings
consistent with the majority of headings.

PR-URL: #22397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Aug 21, 2018
Make space and comma distribution in some headings
consistent with the majority of headings.

PR-URL: #22397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
Make space and comma distribution in some headings
consistent with the majority of headings.

PR-URL: #22397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants