Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http-client-timeout-option-with-agent #22403

Closed
wants to merge 3 commits into from
Closed

test: fix flaky test-http-client-timeout-option-with-agent #22403

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90f3e2f
test: fix flaky http timeout test
Trott Aug 19, 2018
0cd6873
test: move http timeout test to parallel
Trott Aug 19, 2018
d194aae
test: improve assert message in http timeout test
Trott Aug 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...-http-client-timeout-option-with-agent.js → ...-http-client-timeout-option-with-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,11 @@ function doRequest() {
timeout_events += 1;
const duration = Date.now() - start;
// The timeout event cannot be precisely timed. It will delay
// some number of milliseconds, so test it in second units.
assert.strictEqual(duration / 1000 | 0, HTTP_CLIENT_TIMEOUT / 1000);
// some number of milliseconds.
assert.ok(
duration >= HTTP_CLIENT_TIMEOUT,
`duration ${duration}ms less than timeout ${HTTP_CLIENT_TIMEOUT}ms`
);
}));
req.end();

Expand Down