Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve assertions in test-cli-node-print-help #22489

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 23, 2018
@@ -44,11 +44,13 @@ function validateNodePrintHelp() {
function testForSubstring(options) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add:

{ compileConstant: true,
  flags: [
    '-',
    '--',
    '--abort-on-uncaught-exception',
    '-c',
    '--check',
    '-e',
    '--eval script',
    '--experimental-modules',
    '--experimental-repl-await',
    '--experimental-vm-modules',
    '-h',
    '--help',
    '-i',
    '--interactive',
    '--napi-modules',
    '--no-deprecation',
    '--no-force-async-hooks-checks',
    '--no-warnings',
    '-p',
    '--pending-deprecation',
    '--preserve-symlinks',
    '--preserve-symlinks-main',
    '--print',
    '--prof',
    '--prof-process',
    '-r',
    '--redirect-warnings=file',
    '--require',
    '--throw-deprecation',
    '--trace-deprecation',
    '--trace-event-categories',
    '--trace-event-file-pattern',
    '--trace-events-enabled',
    '--trace-sync-io',
    '--trace-warnings',
    '--track-heap-objects',
    '-v',
    '--v8-options',
    '--v8-pool-size=num',
    '--version',
    '--zero-fill-buffers',
    'NODE_DEBUG',
    'NODE_DEBUG_NATIVE',
    'NODE_DISABLE_COLORS',
    'NODE_EXTRA_CA_CERTS',
    'NODE_NO_WARNINGS',
    'NODE_OPTIONS',
    'NODE_PATH',
    'NODE_PENDING_DEPRECATION',
    'NODE_PRESERVE_SYMLINKS',
    'NODE_REDIRECT_WARNINGS',
    'NODE_REPL_HISTORY',
    'OPENSSL_CONF',
  ]
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you submit a PR with that I’ll approve it, yes.

@refack refack added the cli Issues and PRs related to the Node.js command line interface. label Aug 24, 2018
@addaleax
Copy link
Member Author

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2018
@addaleax
Copy link
Member Author

@addaleax
Copy link
Member Author

addaleax commented Sep 2, 2018

Landed in 208022c

@addaleax addaleax closed this Sep 2, 2018
@addaleax addaleax deleted the test-cli-node-print-help branch September 2, 2018 11:49
addaleax added a commit that referenced this pull request Sep 2, 2018
PR-URL: #22489
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Sep 2, 2018
PR-URL: #22489
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
PR-URL: #22489
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2018
PR-URL: #22489
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants