Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction #22596

Closed
wants to merge 1 commit into from
Closed

src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction #22596

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 30, 2018

This is unnecessary, deprecated, and removed in V8 7.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@targos
src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction
1d04841 
This is unnecessary, deprecated, and removed in V8 7.0.
@targos targos added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. dont-land-on-v6.x labels Aug 30, 2018
@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/729/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels Aug 30, 2018
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 30, 2018
@targos
Copy link
Member Author

targos commented Aug 30, 2018

Please 👍 to fast-track. This unbreaks v8-canary.

@targos
Copy link
Member Author

targos commented Aug 30, 2018

No fast tracking?

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 30, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/16875/

@targos
Copy link
Member Author

targos commented Aug 31, 2018 •
edited
Loading

Resumed:https://ci.nodejs.org/job/node-test-pull-request/16890/
Again: https://ci.nodejs.org/job/node-test-pull-request/16891/

@targos
Copy link
Member Author

targos commented Aug 31, 2018

Landed in 98b5d66

@targos targos closed this Aug 31, 2018
@targos targos deleted the CreateCodeCacheForFunction branch August 31, 2018 06:37
targos added a commit that referenced this pull request Aug 31, 2018
@targos
src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction
98b5d66 
This is unnecessary, deprecated, and removed in V8 7.0.

PR-URL: #22596
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Aug 31, 2018
@targos @addaleax
src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction
2fe013f 
This is unnecessary, deprecated, and removed in V8 7.0.

PR-URL: #22596
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Sep 3, 2018
@targos
src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction
a7c0cb8 
This is unnecessary, deprecated, and removed in V8 7.0.

PR-URL: #22596
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos added a commit that referenced this pull request Sep 6, 2018
@targos
src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction
4b1685f 
This is unnecessary, deprecated, and removed in V8 7.0.

PR-URL: #22596
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@apapirovski apapirovski apapirovski approved these changes

@ryzokuken ryzokuken Awaiting requested review from ryzokuken

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @addaleax @apapirovski @cjihrig @devsnek @BridgeAR