Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,win: remove unmatched endlocal statement #22627

Merged
merged 1 commit into from
Sep 4, 2018
Merged

build,win: remove unmatched endlocal statement #22627

merged 1 commit into from
Sep 4, 2018

Conversation

refack
Copy link
Contributor

@refack refack commented Aug 31, 2018

Seems like it's a leftover from c403eeb

Refs: #22582 (review)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/749/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Aug 31, 2018
@refack refack requested review from joaocgreis, addaleax and bzoz and removed request for addaleax August 31, 2018 17:08
@refack
Copy link
Contributor Author

refack commented Aug 31, 2018

/CC @nodejs/platform-windows @nodejs/build-files

@refack refack mentioned this pull request Aug 31, 2018
Closed
2 tasks
addaleax
addaleax approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message typo: orphan (or, alternatively, unmatched or sth like that)

@refack refack force-pushed the remove-vcbuild-orphen branch from 06d2f64 to 0ec9036 Compare August 31, 2018 17:12
@refack refack changed the title build,win: remove orphen statment build,win: remove unmatched endlocal statement Aug 31, 2018
@refack refack force-pushed the remove-vcbuild-orphen branch from 0ec9036 to 48edf2b Compare August 31, 2018 17:13
@refack
Copy link
Contributor Author

refack commented Aug 31, 2018

Commit message typo: orphan (or, alternatively, unmatched or sth like that)

Fixed.

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 1, 2018
@refack
Copy link
Contributor Author

refack commented Sep 3, 2018 •
edited
Loading

Windows only CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20503/
https://ci.nodejs.org/job/node-test-commit-windows-fanned/20504/

@refack
build,win: remove unmatched endlocal statement
4cea01a 
Seems like it's a leftover from c403eeb

PR-URL: nodejs#22627
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@refack refack force-pushed the remove-vcbuild-orphen branch from 48edf2b to 4cea01a Compare September 4, 2018 15:34
@refack
Copy link
Contributor Author

refack commented Sep 4, 2018

landed in 4cea01a

@refack refack merged commit 4cea01a into nodejs:master Sep 4, 2018
@refack refack deleted the remove-vcbuild-orphen branch September 4, 2018 15:35
@refack refack removed the request for review from joaocgreis September 4, 2018 15:36
targos pushed a commit that referenced this pull request Sep 5, 2018
@refack @targos
build,win: remove unmatched endlocal statement
2f9295e 
Seems like it's a leftover from c403eeb

PR-URL: #22627
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@refack @targos
build,win: remove unmatched endlocal statement
b934add 
Seems like it's a leftover from c403eeb

PR-URL: #22627
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzoz bzoz bzoz approved these changes

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@refack @nodejs-github-bot @addaleax @cjihrig @richardlau @BridgeAR @trivikr @bzoz