Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky async-hooks/test-callback-error #22655

Closed
wants to merge 3 commits into from
Closed

test: fix flaky async-hooks/test-callback-error #22655

wants to merge 3 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 2, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/769/pipeline

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Sep 2, 2018
@addaleax
Copy link
Member Author

addaleax commented Sep 2, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/16946/
CI: https://ci.nodejs.org/job/node-test-pull-request/16949/

Please 👍 this comment to allow fast-tracking.

@addaleax addaleax added fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Sep 2, 2018
@addaleax addaleax mentioned this pull request Sep 2, 2018
Closed
lundibundi
lundibundi reviewed Sep 2, 2018
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this comment is also obsolete now https://github.com/nodejs/node/pull/22655/files#diff-0cc0d48d1f2c9d1e273bc03e7f9a0c9bR61 ?

@addaleax
Copy link
Member Author

addaleax commented Sep 2, 2018

@lundibundi Thanks, done!

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 4, 2018
@addaleax
Copy link
Member Author

addaleax commented Sep 5, 2018

Landed in 67bfcb7, 702e114

@addaleax addaleax closed this Sep 5, 2018
@addaleax addaleax deleted the flaky-callback-error branch September 5, 2018 10:40
addaleax added a commit that referenced this pull request Sep 5, 2018
@addaleax
test: fix flaky async-hooks/test-callback-error
67bfcb7 
Remove an unnecessary timeout.

Fixes: #15985

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request Sep 5, 2018
@addaleax
Revert "test: mark async-hooks/test-callback-error as flaky"
702e114 
This reverts commit 59c8abf.

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 5, 2018
@addaleax @targos
test: fix flaky async-hooks/test-callback-error
4791cd7 
Remove an unnecessary timeout.

Fixes: #15985

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 5, 2018
@addaleax @targos
Revert "test: mark async-hooks/test-callback-error as flaky"
7a3bbd2 
This reverts commit 59c8abf.

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@addaleax @targos
test: fix flaky async-hooks/test-callback-error
8792609 
Remove an unnecessary timeout.

Fixes: #15985

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 6, 2018
@addaleax @targos
Revert "test: mark async-hooks/test-callback-error as flaky"
d626372 
This reverts commit 59c8abf.

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@lundibundi lundibundi lundibundi approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig @BridgeAR @lundibundi @gdams